RFR: Small cleanups in java.lang.ref

[Roger Riggs]

Hi Kim,

In the cleanup category also is:JDK-8132984 
<https://bugs.openjdk.java.net/browse/JDK-8132984> incorrect type for 
Reference.discovered

Is that within the scope of 8203028?

Thanks, Roger


On 5/18/18 10:47 AM, Martin Buchholz wrote:
> On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
> wrote:
>
>> Hi,
>>
>> On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote:
>>> I've been confused by NULL vs null for years.
>>>
>>> 8203327: Small cleanups in java.lang.ref
>>> http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup/
>>> https://bugs.openjdk.java.net/browse/JDK-8203327
>>    JDK-8203028 which is currently out for review (http://cr.openjdk.java
>> .net/~kbarrett/8203028/open.02) changes and fixes the comments in that
>> respect apart from other significant changes to reference processing.
>>
>> Pushing this cleanup would just cause merge conflicts for us (the gc
>> team). So this change does not seem to be required any more, i.e. do
>> you mind retracting this RFR and closing this change as duplicate of
>> the other?
>>
>> (I apologize if my speech is too direct, I do not want to offend)
>>
> On the contrary, I'm very happy to see gc team actively maintaining
> java.lang.ref.
> I've reverted changes to Reference.java
>
> http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup-1/