RFR: Small cleanups in java.lang.ref

Martin Buchholz martinrb at google.com
Fri May 18 16:47:51 UTC 2018


On Fri, May 18, 2018 at 8:32 AM, <mark.reinhold at oracle.com> wrote:

>
> What’s missing here is a similar comment on the `Reference.queue` field.
> Suggested text:
>
>     /* When active: queue with which this reference is registered
>      *     pending: queue with which this reference is registered
>      *    enqueued: ReferenceQueue.ENQUEUED
>      *    inactive: ReferenceQueue.NULL
>      */
>
>
I agree Reference.queue should have a comment.


> Martin -- while you’re at it, please lowercase “Enqueued:” and
> “Inactive:” in the other comments, and hard-wrap the comment on
> the `discovered` field to 80 columns.
>

Mark: Kim and Thomas are rewriting those comments over in
http://cr.openjdk.java.net/~kbarrett/8203028/open.02

Kim and Thomas: Take Mark's suggestions into consideration.


More information about the core-libs-dev mailing list