8202076: test/jdk/java/io/File/WinSpecialFiles.java on windows with VS2017

Brian Burkhalter brian.burkhalter at oracle.com
Fri May 18 19:18:24 UTC 2018


On May 18, 2018, at 7:42 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On May 18, 2018, at 7:40 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>>> The offset in the string comparison is necessary as “C:\\pagefile.sys” becomes “pagefile.sys” in fileData.cFileName. I’m not certain that this will work in all cases however but it is certainly no worse than before.
>>> 
>> Can the call to _wstati64 be removed? That is, if GetFileAttributesExW fails with a sharing violation then just use FindFirstFileW as the fallback.
> 
> Had not tried that yet but I will.


_wstati64 branch excised and verified to pass sans and with VS 2017.

http://cr.openjdk.java.net/~bpb/8202076/webrev.01/

Is this good to go?

Thanks,

Brian


More information about the core-libs-dev mailing list