8202076: test/jdk/java/io/File/WinSpecialFiles.java on windows with VS2017

Brian Burkhalter brian.burkhalter at oracle.com
Fri May 18 22:08:46 UTC 2018


Hi Ivan,

On May 18, 2018, at 2:30 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On May 18, 2018, at 2:24 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
>> In fact, we only need to check that that only file name (without the directory name) is the same, so maybe it will be safer to compare the substrings starting at the very last backslash?
>> If the check fails, then we may want to try to see if pathbuf ends with fileData.cAlternateFileName.
> 
> Indeed it might make more sense to locate the last backslash using strrchr or equivalent and then do the comparison against the returned pointers without a length.

Here is another version which incorporates your suggestion:

http://cr.openjdk.java.net/~bpb/8202076/webrev.02/

Thanks,

Brian


More information about the core-libs-dev mailing list