RFR 8203368: ObjectInputStream filterCheck method throws NullPointerException

Brian Burkhalter brian.burkhalter at oracle.com
Mon May 21 15:01:23 UTC 2018


On May 21, 2018, at 5:54 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:

> Please review a fix for the serial filter mechanism to prevent a NPE in the case where
> ObjectInputStream has been subclassed and the input stream is not available.
> 
> Webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-ois-override-8203368/

Hi Roger,

Code looks OK but in the test why  not use the “expectedExceptions” optional element [1] of the @Test annotation and dispense with the nested try-catch constructs?

Thanks,

Brian

[1] https://jitpack.io/com/github/cbeust/testng/master/javadoc/org/testng/annotations/Test.html#expectedExceptions--


More information about the core-libs-dev mailing list