8202076: test/jdk/java/io/File/WinSpecialFiles.java on windows with VS2017
Brian Burkhalter
brian.burkhalter at oracle.com
Tue May 22 23:24:24 UTC 2018
On May 21, 2018, at 10:51 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> Thank you Brian, this looks good to me.
>
> I assume it compiles Okay, though according to MSDN wcsrchr() and wcscmp() require either <string.h> or <wchar.h> to be included (must have been added through one of already included header).
>
> No need for another webrev if you decide to add one of these.
>
Thanks, Ivan. There is no problem with compilation with either the current build system compiler(s) or VS2017.
On May 21, 2018, at 11:24 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 22/05/2018 01:43, Brian Burkhalter wrote:
>> Updated webrev: http://cr.openjdk.java.net/~bpb/8202076/webrev.03/<http://cr.openjdk.java.net/%7Ebpb/8202076/webrev.03/>
>>
> This version checks for a reparse point and looks right. Just some odd formatting at L540/541 that I assume you'll fix but otherwise looks good.
Formatting fixed to be consistent with similar constructs elsewhere in the file.
Pushed.
Thanks,
Brian
More information about the core-libs-dev
mailing list