RFR: 8193154: methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

[Lance Andersen]

Hi Vivek,

The original test has the @Test annotation on the class which indicates that all public methods are test methods:

http://testng.org/doc/documentation-main.html#class-level <http://testng.org/doc/documentation-main.html#class-level>

So adding @Test to each method is OK but not needed.

HTH

Best
Lance


> On May 26, 2018, at 3:51 AM, Vivek Theeyarath <vivek.theeyarath at oracle.com> wrote:
> 
> Hi All,
> 
>               Please review fix for https://bugs.openjdk.java.net/browse/JDK-8193154 . 
> 
> 
> 
> http://cr.openjdk.java.net/~vtheeyarath/8193154/webrev.00/ 
> 
> 
> 
> The test ran fine with Mach5 http://java.se.oracle.com:10065/mdash/jobs/root-jdk-dev-20180526-0645-24095 
> 
> 
> 
> Regards
> 
> Vivek

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>