RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

Roger Riggs Roger.Riggs at oracle.com
Tue Nov 6 16:55:31 UTC 2018


+1

Though with 65 tests, I suspect that there are more cases than strictly 
needed
to cover all the code flows.
For example, three cases for testing when it is the same file doesn't 
seem necessary.

Regards, Roger

On 11/05/2018 11:27 PM, Stuart Marks wrote:
> On 10/19/18 11:26 AM, Joe Wang wrote:
>> Current version:
>> http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v06/
>
> Hi Joe,
>
> Thanks for updating the tests per my comments. Everything looks good now!
>
> s'marks



More information about the core-libs-dev mailing list