RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

[Joe Wang]

Thanks Andrew for pointing that out. It wasn't intentional, a result of 
copy n paste after removing the support class. It's fixed now:
http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v07/

-Joe

On 11/6/18, 10:27 AM, Andrew Luo wrote:
> I'm not a reviewer, but just wanted to point out that the fully qualified Files.BUFFER_SIZE can be simplified to just BUFFER_SIZE.  Searching through the code in Files.java I don't see many other instances of using Files.* (although I do see a few).
>
> Thanks
> Andrew
>
> -----Original Message-----
> From: core-libs-dev<core-libs-dev-bounces at openjdk.java.net>  On Behalf Of Roger Riggs
> Sent: Tuesday, November 6, 2018 8:56 AM
> To: core-libs-dev at openjdk.java.net
> Subject: Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents
>
> +1
>
> Though with 65 tests, I suspect that there are more cases than strictly needed to cover all the code flows.
> For example, three cases for testing when it is the same file doesn't seem necessary.
>
> Regards, Roger
>
> On 11/05/2018 11:27 PM, Stuart Marks wrote:
>> On 10/19/18 11:26 AM, Joe Wang wrote:
>>> Current version:
>>> http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v06/
>> Hi Joe,
>>
>> Thanks for updating the tests per my comments. Everything looks good now!
>>
>> s'marks