6516099: InputStream.skipFully(int k) to skip exactly k bytes

[Daniel Fuchs]

Hi Brian,

I am not sure whether you can trust that a skip implementation
that returns -1 has actually rewind 1 byte - for instance:

http://hg.openjdk.java.net/jdk/jdk/file/44f34d2c3243/src/java.desktop/share/classes/com/sun/media/sound/AudioFloatInputStream.java#l99

Not sure there's anything that could be done in such cases, except
encouraging such subclasses to provide their own implementation
of skipNBytes?

best regards,

--- daniel

On 06/11/2018 21:30, Brian Burkhalter wrote:
> Hello again,
> 
> I updated the patch to address the comments made by Roger and Daniel:
> 
> http://cr.openjdk.java.net/~bpb/6516099/webrev.05/
> 
> Specifically, the method is implemented in terms of skip() and read() and attempts to account for the possible behaviors of the former, and most of the specification is moved to an @implSpec block.
> 
> The tests are intentionally not updated until such time as agreement on the method itself might be achieved.
> 
> Thanks,
> 
> Brian
>