RFR: JDK-8213480: update internal ASM version to 7.0

David Holmes david.holmes at oracle.com
Thu Nov 8 03:03:40 UTC 2018


Hi Vicente,

All of the javadoc comment reformatting makes it nearly impossible to 
see the actual substantive changes :(

ASM 7 also supports the Nestmate attributes and I was trying to see 
how/where that appeared but its somewhat obscure. Oh well.

Is it that case that the code the uses the ASM library, like the JFR 
code and jlink code, and the tests, doesn't actually _have to_ change to 
specifying Opcodes.ASM7 unless they plan on using ASM7 features? If so 
then you could split out the actual update of ASM from the updates to 
the users of ASM (some of which may be quite fine with ASM5).

Thanks,
David

On 8/11/2018 1:56 AM, Vicente Romero wrote:
> Hi,
> 
> Version 7.0 of ASM has been released. This version supports condy, yay!, 
> and we want to include it in JDK 12. Please review [1] which includes:
> - the new version perse substituting the preview ASM internal version in 
> the JDK
> - changes to additional files in particular some tests, mostly hotspot 
> tests.
> 
> Thanks,
> Vicente
> 
> [1] http://cr.openjdk.java.net/~vromero/8213480/webrev.00/


More information about the core-libs-dev mailing list