6516099: InputStream.skipFully(int k) to skip exactly k bytes
Brent Christian
brent.christian at oracle.com
Sat Nov 10 00:41:57 UTC 2018
On 11/9/18 2:04 PM, Brian Burkhalter wrote:
> An updated patch is at
>
> http://cr.openjdk.java.net/~bpb/6516099/webrev.06/ <http://cr.openjdk.java.net/~bpb/6516099/webrev.06/>
>
> including a revision of the implementation to align with the words. The tests are not updated yet.
>
I think this looks quite good.
My only comment is that
568 * If {@code n} is zero or negative, then no bytes are skipped.
seems a bit redundant, given the opening paragraph. I could take it or
leave it.
Thanks,
-Brent
More information about the core-libs-dev
mailing list