RFR: 8213741: Consolidate Object and String Stringifiers
Aleksey Shipilev
shade at redhat.com
Mon Nov 12 15:56:34 UTC 2018
On 11/12/2018 03:24 PM, Claes Redestad wrote:
> Webrev: http://cr.openjdk.java.net/~redestad/8213741/jdk.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8213741
Looks good to me.
*) Not sure this is significantly better than String.valueOf(String.valueOf(s)), as original comment
suggests:
1701 String s;
1702 return (value == null || (s = value.toString()) == null) ? "null" : s;
*) Do you really want new "static finals" be "private" as well? It seems to me the classes are
private already, and maybe dropping some privates help to avoid some bridge methods? (Probably
obsolete by nestmates, but still). It probably does not matter all that much for bootstrap code.
-Aleksey
More information about the core-libs-dev
mailing list