JDK-8212780: JEP 343: Packaging Tool Implementation

[Andrew Luo]

I noticed in WindowsRegistry.java we're actually making calls to reg(.exe) and parsing the output/result.  Is this preferred over making direct calls to the WINAPI functions via JNI?  (Also, would this be a security concern if another reg.exe is in the PATH before the Windows system one?)

Also:

131                 ProcessBuilder security = new ProcessBuilder(buildOptions);
 132                 exec(security, false, false, ps);

the variable name security for the ProcessBuilder seems like it may have been some leftover from refactoring...

Thanks,
-Andrew

-----Original Message-----
From: core-libs-dev <core-libs-dev-bounces at openjdk.java.net> On Behalf Of Andy Herrick
Sent: Friday, November 9, 2018 2:26 PM
To: core-libs-dev at openjdk.java.net
Subject: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

This is an update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool <https://bugs.openjdk.java.net/browse/JDK-8200758>

This refresh renames the packages used to jdk.jpackager and jdk.jpackager.runtime, removes the JNLPConverter demo, adds an initial set of automated tests, and contains fixes to the following issues:

JDK-8213324 jpackager deletes existing app directory without warning
JDK-8213166 jpackager --argument arg is broken
JDK-8213163 --app-image arg does not work creating exe installers
JDK-8212089 Prepare packager for localization
JDK-8212537 Create method and class description comments for main functionality
JDK-8213332 Create minimal automated tests for jpackager
JDK-8213333 Fix issues found in jpackager with automated tests
JDK-8213394 Stop using Log.info() except for expected output.
JDK-8213345 Secondary Launchers broken on mac.
JDK-8213156 rename packages for jpackager
JDK-8213244 Fix all warnings in jpackager java code
JDK-8212143 Remove native code that supports UserJvmOptionsService
JDK-8213162 Association description in Inno Setup cannot contain double quotes

The following additional issues are targeted to be address in the next few weeks:
JDK-8212936     Makefile and other improvements for jpackager
JDK-8212164     resolve jre.list and jre.module.list
JDK-8213392     Enhance --help and --version
JDK-8208652     File name is not passed to main() via file association on OS X
JDK-8212538     Determine standard way to determine if a Modular jar
JDK-8213558     Create more unit tests

Webrev: http://cr.openjdk.java.net/~herrick/8212780/webrev.2/

please send feedback to core-libs-dev at openjdk.java.net

/Andy Herrick