RFR 4947890 : Minimize JNI upcalls in system property initialization
Erik Joelsson
erik.joelsson at oracle.com
Fri Nov 16 20:36:41 UTC 2018
Thanks, looks good to me now.
/Erik
On 2018-11-16 12:02, Roger Riggs wrote:
> Hi Erik,
>
> Yes, that is removed.
> Webrev updated in place.
>
> Thanks, Roger
>
> http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw/
>
> On 11/16/2018 02:37 PM, Erik Joelsson wrote:
>> Does this mean we can remove $(VERSION_CFLAGS) from System.c in
>> make/lib/CoreLibraries.gmk?
>>
>> Otherwise this looks good from a build point of view.
>>
>> /Erik
>>
>> On 2018-11-16 10:49, Roger Riggs wrote:
>>> Updates to include the suggestions made by Mandy and Brent:
>>>
>>> - Move the build-time properties from native code to the
>>> VersionProps.java.template
>>> including java.vendor.* and java.specification.* properties, plus
>>> the java.class.version (major.minor)
>>> This included two changes to the build that generates source of
>>> VersionProps.java.
>>>
>>> - Updated the StaticProperty initialization to be explicitly
>>> invoked by initProperties.
>>>
>>> - Makes separate calls to native to retrieve the platform
>>> properties and VM/command line properties
>>>
>>> - (The hotspot function for JVM_GetProperties are unchanged)
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw/
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-4947890
>>>
>>> Thanks, Roger
>>>
>>>
>
More information about the core-libs-dev
mailing list