6516099: InputStream.skipFully(int k) to skip exactly k bytes
Daniel Fuchs
daniel.fuchs at oracle.com
Wed Nov 28 17:51:01 UTC 2018
Looks good to me Brian.
I never knew whether positive meant >= 0 or > 0 anyway ;-)
best regards,
-- daniel
On 28/11/2018 17:38, Brian Burkhalter wrote:
> Hello again,
>
> One, hopefully final, one sentence change was requested in a comment on the CSR:
>
> --- a/src/java.base/share/classes/java/io/InputStream.java
> +++ b/src/java.base/share/classes/java/io/InputStream.java
> @@ -567,6 +567,7 @@
> * of this method.
> *
> * @implSpec
> + * If {@code n} is zero or negative, then no bytes are skipped.
> * If {@code n} is positive, the default implementation of this method
> * invokes {@link #skip(long) skip()} with parameter {@code n}. If the
> * return value of {@code skip(n)} is non-negative and less than {@code n},
>
> http://cr.openjdk.java.net/~bpb/6516099/webrev.08/
>
> If this looks good then I will update the CSR accordingly and when that is approved push the change.
>
> Thanks,
>
> Brian
>
>> On Nov 21, 2018, at 9:35 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>>
>> Looks fine Brian!
>>
>> On 11/21/2018 12:19 PM, Brian Burkhalter wrote:
>>> Hello, again,
>>>
>>> In response to comments on the CSR
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8214072
>
More information about the core-libs-dev
mailing list