RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary
David Holmes
david.holmes at oracle.com
Thu Nov 29 05:00:19 UTC 2018
Hi Thomas,
On 29/11/2018 2:37 pm, Thomas Stüfe wrote:
> Hi all,
>
> Will the failed test jobs be automatically re-submitted or should we do
> that manually?
Do you mean for the submit-repo?
I'd pull/rebase to get all recent fixes as there was a Mac build fix
that just went in too - then resubmit.
Cheers,
David
> Thanks, Thomas
>
> On Thu, Nov 29, 2018, 00:43 Hamlin Li <huaming.li at oracle.com
> <mailto:huaming.li at oracle.com> wrote:
>
> Hi,
>
> Thank you for reviewing this, it's just pushed, I'm sorry for the
> inconvenience.
>
> Thank you
>
> -Hamlin
>
> On 2018/11/29 5:12 AM, Chris Hegarty wrote:
> > I think this good. Thanks.
> >
> > -Chris.
> >
> >> On 28 Nov 2018, at 20:32, David Holmes <david.holmes at oracle.com
> <mailto:david.holmes at oracle.com>> wrote:
> >>
> >> Hi Hamlin,
> >>
> >> On 28/11/2018 10:52 pm, Hamlin Li wrote:
> >>> Hi David,
> >>> Yes, they'd better be removed too, so I create another bug
> https://bugs.openjdk.java.net/browse/JDK-8214435 to track it.
> >> Ok.
> >>
> >>> With only /lib/testlibrary/, tests will not fail, tests only
> fail when there is something like "run build jdk.testlibrary.*"
> >> Ok.
> >>
> >>> So, I think in this bug it's OK to just address failed tests,
> and address complete removal of /lib/testlibrary/ in JDK-8214435.
> >> Ok. :)
> >>
> >> I would have expected core-libs folk to have reviewed this by
> now so that it could have been pushed! This is causing major
> disruption to the CI testing! :(
> >>
> >> Thanks,
> >> David
> >>
> >>> Thank you
> >>> -Hamlin
> >>> On 2018/11/28 8:08 PM, David Holmes wrote:
> >>>> Hi Hamlin,
> >>>>
> >>>> On 28/11/2018 9:15 pm, Hamlin Li wrote:
> >>>>> Hi David,
> >>>>>
> >>>>> Thank a lot for double checking the usage of testlibrary.
> >>>>>
> >>>>> I have updated the patch,
> http://cr.openjdk.java.net/~mli/8214431/webrev.00/
> >>>> I'm not sure about the removal of /lib/testlibrary/ from
> >>>>
> >>>> @library /lib/testlibrary/ /test/lib
> >>>>
> >>>> as there are dozens of tests that refer to
> >>>>
> >>>> @library /lib/testlibrary/
> >>>>
> >>>> either directly or via a relative path. Do they all need to be
> changed ?? Or none?
> >>>>
> >>>> David
> >>>>
> >>>> PS. I'm finished for the night.
> >>>>
> >>>>> Thank you
> >>>>>
> >>>>> -Hamlin
> >>>>>
> >>>>> On 2018/11/28 6:24 PM, David Holmes wrote:
> >>>>>> Hi Hamlin,
> >>>>>>
> >>>>>> I see a lot more tests that look like they may be affected:
> >>>>>>
> >>>>>> ./jdk/com/sun/tools/attach/TempDirTest.java: * @run build
> jdk.testlibrary.* Application RunnerUtil
> >>>>>> ./jdk/com/sun/tools/attach/PermissionTest.java: * @run build
> jdk.testlibrary.* Application
> >>>>>> ./jdk/com/sun/tools/attach/BasicTests.java: * @run build
> jdk.testlibrary.* Agent BadAgent RedefineAgent Application
> RedefineDummy RunnerUtil
> >>>>>> ./jdk/com/sun/tools/attach/ProviderTest.java: * @run build
> jdk.testlibrary.* SimpleProvider
> >>>>>> ./jdk/com/sun/jdi/ProcessAttachTest.java: * @build
> jdk.testlibrary.* ProcessAttachTest
> >>>>>> ./jdk/java/lang/Thread/ThreadStateTest.java: * @build
> jdk.testlibrary.*
> >>>>>>
> ./jdk/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java:
> * @build jdk.testlibrary.* CollectionUsageThreshold MemoryUtil RunUtil
> >>>>>>
> ./jdk/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java: *
> @build jdk.testlibrary.* ResetPeakMemoryUsage MemoryUtil RunUtil
> >>>>>>
> ./jdk/java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java:
> * @build jdk.testlibrary.*
> >>>>>> ./jdk/sun/management/jmxremote/startstop/JMXStatusTest.java:
> * @build jdk.testlibrary.* PortAllocator TestApp ManagementAgentJcmd
> >>>>>>
> ./jdk/sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java:
> * @build jdk.testlibrary.* PortAllocator TestApp ManagementAgentJcmd
> >>>>>>
> ./jdk/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java:
> * @build jdk.testlibrary.* jdk.test.lib.Platform Dummy
> AbstractFilePermissionTest
> >>>>>>
> ./jdk/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.java:
> * @build jdk.testlibrary.* jdk.test.lib.Platform
> AbstractFilePermissionTest Dummy
> >>>>>>
> >>>>>> Cheers,
> >>>>>> David
> >>>>>> -----
> >>>>>>
> >>>>>> On 28/11/2018 8:14 pm, Hamlin Li wrote:
> >>>>>>> Would you please review the following patch?
> >>>>>>>
> >>>>>>> This is a regression by JDK-8211975.
> >>>>>>>
> >>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8214431
> >>>>>>>
> >>>>>>> patch at the bottom.
> >>>>>>>
> >>>>>>> Thank you
> >>>>>>>
> >>>>>>> -Hamlin
> >>>>>>>
> >>>>>>>
> ------------------------------------------------------------------------
> >>>>>>>
> >>>>>>> diff -r 70adb0f573a7
> test/jdk/com/sun/jdi/ProcessAttachTest.java
> >>>>>>> --- a/test/jdk/com/sun/jdi/ProcessAttachTest.java Wed
> Nov 28 15:34:43 2018 +0800
> >>>>>>> +++ b/test/jdk/com/sun/jdi/ProcessAttachTest.java Wed
> Nov 28 18:13:49 2018 +0800
> >>>>>>> @@ -38,11 +38,10 @@
> >>>>>>> * @bug 4527279
> >>>>>>> * @summary Unit test for ProcessAttachingConnector
> >>>>>>> *
> >>>>>>> - * @library /lib/testlibrary
> >>>>>>> * @library /test/lib
> >>>>>>> * @modules java.management
> >>>>>>> * jdk.jdi
> >>>>>>> - * @build jdk.testlibrary.* ProcessAttachTest
> >>>>>>> + * @build ProcessAttachTest
> >>>>>>> * @run driver ProcessAttachTest
> >>>>>>> */
> >>>>>>>
> >>>>>>> diff -r 70adb0f573a7
> test/jdk/java/lang/Thread/ThreadStateTest.java
> >>>>>>> --- a/test/jdk/java/lang/Thread/ThreadStateTest.java Wed
> Nov 28 15:34:43 2018 +0800
> >>>>>>> +++ b/test/jdk/java/lang/Thread/ThreadStateTest.java Wed
> Nov 28 18:13:49 2018 +0800
> >>>>>>> @@ -30,9 +30,7 @@
> >>>>>>> * Thread.getState().
> >>>>>>> *
> >>>>>>> * @author Mandy Chung
> >>>>>>> - * @library /lib/testlibrary
> >>>>>>> * @library /test/lib
> >>>>>>> - * @build jdk.testlibrary.*
> >>>>>>> * @build jdk.test.lib.LockFreeLogger
> >>>>>>> * @build ThreadStateTest ThreadStateController
> >>>>>>> * @run main/othervm -Xmixed ThreadStateTest
> >>>>>>>
> >>>>>>>
>
More information about the core-libs-dev
mailing list