RFR 8211295: DriverManager.getConnection fails when called from com.sun.rowset.JdbcRowSetImpl

[Lance Andersen]

> On Oct 1, 2018, at 1:09 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
> 
> On 9/29/18 1:59 PM, Lance Andersen wrote:
>> Attached is the webrev for the JDBC RowSet/DriverManager issue, https://bugs.openjdk.java.net/browse/JDK-8211295 <https://bugs.openjdk.java.net/browse/JDK-8211295>,  that was raised on the thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055755.html <http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055755.html>
>> 
>> I have run the JDBC TestSuite against the Derby Embedded and Derby Network server;  Mach 5 jdk tier1, tier2, and tier3 tests as well as the JCK java.sql and javax.sql tests.  All pass with the fix
>> 
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/8211295/webrev.00/ <http://cr.openjdk.java.net/~lancea/8211295/webrev.00/>
> 
> The change looks okay.    DriverManager::drivers and a few other methods are caller-sensitive.  If they were called from java.sql.rowset, it won't work properly.   I believe no such code path and so it's okay.

That is correct, only DriverManager::getConnection is called

> 
> We should try again to investigate removing @CallerSensitive from DriverManager in the future:
>    https://bugs.openjdk.java.net/browse/JDK-8154346 <https://bugs.openjdk.java.net/browse/JDK-8154346>

OK, let the fun times begin ;-) 
> 
> Mandy

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>