RFR JDK-8211728,JarFile::versionedStream() does not filter META-INF resources in versioned stream
Alan Bateman
Alan.Bateman at oracle.com
Mon Oct 8 20:01:28 UTC 2018
On 08/10/2018 20:01, Xueming Shen wrote:
> On 10/6/18, 1:54 AM, Alan Bateman wrote:
>>
>>
>> On 06/10/2018 09:29, Xueming Shen wrote:
>>> The created mr jar file is being tested in #139 with
>>> versionedStream(). Without the fix there will be a npe.
>> Right but it's not testing that the versioned stream doesn't include
>> META-INF/Foo.class. We need some test for this to be confident that
>> the versioned stream never includes resources from META-INF in the
>> versioned section.
>>
>> -Alan
> Hi Alan,
>
> webrev has been updated to include the test case of testing if
> META-INF/Foo.class
> entry exists in versionedStream() output.
>
> http://cr.openjdk.java.net/~sherman/8211728/webrev
Thanks for adding the test, I think it looks good now.
-Alan
More information about the core-libs-dev
mailing list