RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue
Alan Bateman
Alan.Bateman at oracle.com
Tue Oct 9 12:05:40 UTC 2018
On 09/10/2018 12:40, Baesken, Matthias wrote:
> Hello, please review the following change .
> It enhances a number of JNU_ThrowIOExceptionWithLastError calls with path and current working directory information.
> For this, a new function JNU_ThrowIOExceptionWithLastErrorAndPath is added.
>
> bug and webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8211752
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211752.0/
>
This patch will need security review as it leaks sensitive information
into exception messages. It may be that it needs to predicated on a
security property.
If this proposal goes ahead then the implementation needs cleanup. The
upcall from the JNU_* function to jdk.internal.util is a messy I think
we need to look at alternative to avoid this. Also the patch needs to be
re-formatted to get it consistent with the existing code (e.g. overly
long 150 character lines need to be trimmed down to be consistent with
the existing code for example).
-Alan
More information about the core-libs-dev
mailing list