RFR: 8211962: Implicit narrowing in MacOSX java.desktop jsound
Kim Barrett
kim.barrett at oracle.com
Wed Oct 10 01:24:35 UTC 2018
> On Oct 9, 2018, at 7:22 PM, Philip Race <philip.race at oracle.com> wrote:
>
> Wrong list. Try over on sound-dev,
Thanks. I didn’t notice that one when looking through the list of lists.
>
> -phil.
>
> On 10/9/18, 4:17 PM, Kim Barrett wrote:
>> [I'm not sure whether core-libs is the right list for java.desktop changes.]
>>
>> Please review this trivial fix of a build failure on MacOSX when
>> compiling with C++11/14 enabled. An int value is being used in an
>> initializer where an unsigned int is needed, which is not permitted
>> since C++11. The solution taken is to cast the value in the
>> initializer. A "better" solution would be to change the type of the
>> value, but that has substantial fannout because there are many places
>> in our code where signed ints were used instead of the unsigned ints
>> used by the underlying MacOSX framework.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8211962
>>
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8211962/open.00/
>>
>> Testing:
>> mach5 tier1 on MacOSX (really just verifying it builds).
More information about the core-libs-dev
mailing list