RFR of JDK-8186610,move ModuleUtils to top-level testlibrary

Hamlin Li huaming.li at oracle.com
Thu Oct 11 03:26:05 UTC 2018


Hi Igor,

Would you please clarify your concern further? I mean why 
ModuleTargetHelper can be put to top level when it use non-public APIs 
e.g. jdk.internal.module.*?

Thank you

-Hamlin

On 2018/10/11 11:08 AM, Igor Ignatyev wrote:
> Hi Hamlin,
>
> as ModuleTargetHelper uses non-public API, I'd prefer not to have in a common test library, and 8211976 suggests moving it closer to tests. could you please explain why you decided to put it into the library instead?
>
> Thanks,
> -- Igor
>
> ----- Original Message -----
> From: huaming.li at oracle.com
> To: core-libs-dev at openjdk.java.net
> Sent: Wednesday, October 10, 2018 7:40:34 PM GMT -08:00 US/Canada Pacific
> Subject: RFR of JDK-8186610,move ModuleUtils to top-level testlibrary
>
> Would you please review the following patch?
>
> bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8186610
>
>     https://bugs.openjdk.java.net/browse/JDK-8211976
>
> webrev: http://cr.openjdk.java.net/~mli/8186610/
>
>
> Thank you
>
> -Hamlin
>



More information about the core-libs-dev mailing list