RFR of JDK-8211974,move testlibrary/java/util/jar/CreateMultiReleaseTestJars.java to a separate testlibrary

Hamlin Li huaming.li at oracle.com
Fri Oct 12 06:16:21 UTC 2018


yes, e.g. https://bugs.openjdk.java.net/browse/JDK-8212033

Thank you

-Hamlin


On 2018/10/12 2:13 PM, Amy Lu wrote:
> Hi, Hamlin
>
> - test/lib/jdk/test/lib/compiler/Compiler.java (was 
> test/jdk/lib/testlibrary/java/util/jar/Compiler.java)
> Any future plan to "merge" it with existing 
> jdk.test.lib.compiler.CompilerUtils?
>
> - test/lib/jdk/test/lib/util/JarBuilder.java (was 
> test/jdk/lib/testlibrary/java/util/jar/JarBuilder.java)
> Any future plan to "merge" it with existing jdk.test.lib.util.JarUtils?
>
> Thanks,
> Amy
>
> On 2018/10/12 2:00 PM, Hamlin Li wrote:
>> Hi Igor,
>>
>> It's updated in place 
>> http://cr.openjdk.java.net/~mli/8211974/webrev.00/, please review it 
>> again.
>>
>> Thank you
>>
>> -Hamlin
>>
>>
>> On 2018/10/12 1:34 PM, Igor Ignatyev wrote:
>>> Hi Hamlin,
>>>
>>> could you please move jdk.test.lib.util.Compiler to j.t.l.compiler 
>>> package? we use this package for classes which have dependency on 
>>> jdk.compiler and/or java.compiler module.
>>>
>>> it'd also be nice to put CreateMultiReleaseTestJars into a named 
>>> package.
>>>
>>> -- Igor
>>>> On Oct 11, 2018, at 10:23 PM, Hamlin Li <huaming.li at oracle.com> wrote:
>>>>
>>>> would you please review the following patch?
>>>>
>>>> bug:
>>>>
>>>>    https://bugs.openjdk.java.net/browse/JDK-8211974
>>>>
>>>>    https://bugs.openjdk.java.net/browse/JDK-8211972
>>>>
>>>>    https://bugs.openjdk.java.net/browse/JDK-8211973
>>>>
>>>>    https://bugs.openjdk.java.net/browse/JDK-8211979
>>>>
>>>> webrev: http://cr.openjdk.java.net/~mli/8211974/webrev.00/
>>>>
>>>> Thank you
>>>>
>>>> -Hamlin
>>>>
>>
>



More information about the core-libs-dev mailing list