JDK 12 RFR of JDK-6304578: (reflect) toGenericString fails to print bounds of type variables on generic methods
Peter Levart
peter.levart at gmail.com
Wed Oct 17 22:07:05 UTC 2018
Hi Joe,
On 10/17/2018 09:16 PM, joe darcy wrote:
> PS In response to some off-list feedback, an updated webrev uses a
> stream-ier implementation:
>
> http://cr.openjdk.java.net/~darcy/6304578.1/
I suggest further niceing:
- if you make typeVarBounds() static, you could use it in Stream.map()
as a method reference.
- in Class.java line 285, you could also use Type::getTypeName method
reference
- in Class.java line 269, wouldn't the output be nicer if the delimiter
in joining collector was ", " instead of "," (with a space after comma)?
The same for Executable.
Regards, Peter
>
> Thanks,
>
> -Joe
>
>
> On 10/11/2018 6:11 PM, joe darcy wrote:
>> Hello,
>>
>> Prompted by recent work on the toString implementations of
>> AnnotatedType objects
>> (http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-October/055937.html),
>> I rediscovered a long-standing limitation of toGenericString on Type
>> objects that can be addressed:
>>
>> JDK-6304578: (reflect) toGenericString fails to print bounds of
>> type variables on generic methods
>>
>> Please review the small CSR
>>
>> https://bugs.openjdk.java.net/browse/JDK-8212094
>>
>> and webrev:
>>
>> http://cr.openjdk.java.net/~darcy/6304578.0/
>>
>> Thanks,
>>
>> -Joe
>>
>
More information about the core-libs-dev
mailing list