[PATCH] Fix typo in javadoc for java.lang.ref.Cleaner

Lance Andersen lance.andersen at oracle.com
Thu Oct 18 13:42:27 UTC 2018


Andrew,

I can sponsor your change
> On Oct 17, 2018, at 5:18 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> +1
>> On Oct 17, 2018, at 4:50 PM, Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>> wrote:
>> 
>> Done as well, thanks for spotting that also.
>>  
>> diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java b/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> --- a/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> +++ b/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> @@ -100,8 +100,8 @@
>>   *            }
>>  *        }
>>   *
>> - *        private final State;
>> - *        private final Cleaner.Cleanable cleanable
>> + *        private final State state;
>> + *        private final Cleaner.Cleanable cleanable;
>>   *
>>   *        public CleaningExample() {
>>   *            this.state = new State(...);
>>  
>> Thanks,
>>  
>> -Andrew
>>  
>> From: Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> 
>> Sent: Wednesday, October 17, 2018 11:33 AM
>> To: Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>>
>> Cc: core-libs-dev at openjdk.java.net <mailto:core-libs-dev at openjdk.java.net>
>> Subject: Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner
>>  
>> Change seems to make sense
>>  
>> looks like a semi-colon could be added after  as well as part of the update:
>>  
>> private final Cleaner.Cleanable cleanable 
>>  
>>  
>>  
>> On Oct 17, 2018, at 2:10 PM, Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>> wrote:
>>  
>> Noticed a typo in the Javadoc for Cleaner... Patch attached below:
>> 
>> diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java b/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> --- a/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> +++ b/src/java.base/share/classes/java/lang/ref/Cleaner.java
>> @@ -100,7 +100,7 @@
>>  *            }
>>  *        }
>>  *
>> - *        private final State;
>> + *        private final State state;
>>  *        private final Cleaner.Cleanable cleanable
>>  *
>>  *        public CleaningExample() {
>> 
>> Thanks,
>> 
>> Andrew
>>  
>> <image001.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> 
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>  
>> 
>> 
>>  
> 
> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list