RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

[Baesken, Matthias]

Hello,  please  review my updated webrev :


http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.1/

-  check changed to  build number of  recently    released  Windows  Server 2019  GA version (17763)  
-  adjusted comments a bit


( see also  

https://en.wikipedia.org/wiki/Windows_Server_2019

for the list  of build numbers )

Thanks, Matthias


> -----Original Message-----
> From: Baesken, Matthias
> Sent: Freitag, 12. Oktober 2018 08:57
> To: 'Bob Vandette' <bob.vandette at oracle.com>
> Cc: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>;
> 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>;
> Langer, Christoph <christoph.langer at sap.com>
> Subject: RE: RFR : 8211106: [windows] Update OS detection code to
> recognize Windows Server 2019
> 
> I got the  info that the GA   of  Windows Server 2019 has build number   17763
> .
> Should I update the webrev to check this build number (would mean we do
> not detect the preview as Windows Server 2019) ,  or keep  it the way it is ?
> 
> Current webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/
> 
> 
> Best regards, Matthias
> 
> 
> 
> >
> > Hello Bob,
> >
> > > Hi Bob,
> > >      no problem ,  we can wait a few  days  until   the final version of Win
> > server
> > > 2019   is out, and check the buildNumber   again :
> > >
> >
> > seems  Windows server 2019  is GA now :
> >
> >
> > https://cloudblogs.microsoft.com/windowsserver/2018/10/02/windows-
> > server-2019-now-generally-available/
> >
> > > > We don’t usually add logic to the JDK related to unreleased operating
> > system
> > > > previews.
> >
> >
> > so I think we can process with the review .
> > Still have to find out the buildNumber of the GA version, probably it has
> been
> > incremented again .
> >
> > > > >
> > > > > Bug/webrev :
> > > > >
> > > > > https://bugs.openjdk.java.net/browse/JDK-8211106
> > > > >
> > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/
> > > > >
> > > > >
> > > > > Thanks, Matthias