[12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Chris Yin xu.y.yin at oracle.com
Fri Oct 19 01:22:44 UTC 2018


Thank you, Roger

Chris

> On 19 Oct 2018, at 2:56 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
> 
> Hi Chris,
> 
> Looks ok.
> 
> Roger
> 
> 
> On 08/20/2018 03:24 AM, vyom tewari wrote:
>> Hi Chris,
>> 
>> Latest webrev(.02) looks good to me. One minor comment i will suggest you to  expand "setContext" as you did for other JNDI tests.
>> 
>> Thanks,
>> 
>> Vyom
>> 
>> 
>> On Friday 10 August 2018 02:34 PM, Chris Yin wrote:
>>> Sorry... another minor revision to handle @Override line and imports place, new webrev as below, thanks
>>> 
>>> http://cr.openjdk.java.net/~xyin/8208542/webrev.02/
>>> 
>>> Regards,
>>> Chris
>>> 
>>>> On 8 Aug 2018, at 2:51 PM, Chris Yin <xu.y.yin at oracle.com> wrote:
>>>> 
>>>> Minor revision to address javadoc, initContext() expansion, vararg etc. webrev as below, thanks
>>>> 
>>>> http://cr.openjdk.java.net/~xyin/8208542/webrev.01/
>>>> 
>>>> Regards,
>>>> Chris
>>>> 
>>>>> On 31 Jul 2018, at 2:39 PM, Chris Yin <xu.y.yin at oracle.com> wrote:
>>>>> 
>>>>> Please review the changes to add 4 JNDI tests to com/sun/jndi/dns/ListTests/ in OpenJDK, thanks
>>>>> 
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8208542
>>>>> webrev: http://cr.openjdk.java.net/~xyin/8208542/webrev.00/
>>>>> 
>>>>> Regards,
>>>>> Chris
>> 
> 
> -- 
> Thanks, Roger



More information about the core-libs-dev mailing list