RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

[Baesken, Matthias]

>

>java_props_md.c: 564.

>

>Please move the buildNumber check inside the "case 0:" above.

>Then it won't need the extra check for minorVersion == 0.
>

Thanks for the remarks ,   I updated  my changes , new webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.2/



Best regards, Matthias

From: Bob Vandette <bob.vandette at oracle.com>
Sent: Donnerstag, 18. Oktober 2018 16:36
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: hotspot-dev at openjdk.java.net; core-libs-dev at openjdk.java.net; Langer, Christoph <christoph.langer at sap.com>
Subject: Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

It sounds like this is still not the last one but I’m ok with your check since the real GA will be higher and we’re real close.


"On October 6, 2018, distribution of Windows version 1809 (build 17763[18]<https://en.wikipedia.org/wiki/Windows_Server_2019#cite_note-18>) was paused while Microsoft is investigating an issue with user data being deleted during an in-place upgrade.[19]<https://en.wikipedia.org/wiki/Windows_Server_2019#cite_note-19> It affected systems where a user profile folder (e.g. Documents, Music or Pictures) had been moved to another location, but data was left in the original location.[20]<https://en.wikipedia.org/wiki/Windows_Server_2019#cite_note-20>As Windows Server 2019 is based on the Windows version 1809 codebase, it too was removed from distribution.[21]<https://en.wikipedia.org/wiki/Windows_Server_2019#cite_note-21>””


Bob.


On Oct 18, 2018, at 10:30 AM, Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:

Hello,  please  review my updated webrev :


http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.1/

-  check changed to  build number of  recently    released  Windows  Server 2019  GA version (17763)
-  adjusted comments a bit


( see also

https://en.wikipedia.org/wiki/Windows_Server_2019

for the list  of build numbers )

Thanks, Matthias



-----Original Message-----
From: Baesken, Matthias
Sent: Freitag, 12. Oktober 2018 08:57
To: 'Bob Vandette' <bob.vandette at oracle.com<mailto:bob.vandette at oracle.com>>
Cc: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>>;
'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net>>;
Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>
Subject: RE: RFR : 8211106: [windows] Update OS detection code to
recognize Windows Server 2019

I got the  info that the GA   of  Windows Server 2019 has build number   17763
.
Should I update the webrev to check this build number (would mean we do
not detect the preview as Windows Server 2019) ,  or keep  it the way it is ?

Current webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/


Best regards, Matthias





Hello Bob,


Hi Bob,
    no problem ,  we can wait a few  days  until   the final version of Win
server

2019   is out, and check the buildNumber   again :

seems  Windows server 2019  is GA now :


https://cloudblogs.microsoft.com/windowsserver/2018/10/02/windows-
server-2019-now-generally-available/


We don’t usually add logic to the JDK related to unreleased operating
system

previews.


so I think we can process with the review .
Still have to find out the buildNumber of the GA version, probably it has
been

incremented again .



Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8211106

http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.0/webrev/


Thanks, Matthias