[12] RFR of JDK-8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test

[Brent Christian]

Hi, Amy

I think this looks quite good as it is.  Just a couple very minor 
comments, that you can take or leave:

* I don't think a List<String> is needed for the 'expected' argument, it 
can just be a String.  The @DataProvider should be able to return 
Object[]s of a List<String> and a String.

* Really, the argument to PrefsSpi is a regex pattern, rather than an 
expected result.

So overall testProvider() could look like:

     public void testProvider(List<String> opts, String pattern) throws 
Throwable

* Also, maybe update the comment (+ copyright year, I suppose) in 
PrefsSpi.java:

/*
  * main class used by regtest PrefsSpi.sh
  */

Thanks,
-Brent

On 10/22/18 8:44 PM, Amy Lu wrote:
> java/util/prefs/PrefsSpi.sh
> 
> Please review this patch to refactor above shell script test to java.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8210908
> webrev: http://cr.openjdk.java.net/~amlu/8210908/webrev.00/
> 
> Thanks,
> Amy