[12] RFR of JDK-8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test

Amy Lu amy.lu at oracle.com
Wed Oct 24 09:04:07 UTC 2018


On 2018/10/24 2:24 AM, Brent Christian wrote:
> Hi, Amy
>
> So one difference from the original test is that the process that 
> creates the preferences store is still active at the time that the 
> preference is checked.  I don't know if this is material to what is 
> being tested or not.
>
> It would be more similar to the original test to keep 
> CheckUserPrefFirst.java and CheckUserPrefLater.java, and have the new 
> CheckUserPrefsStorage.java behave more like the original script and 
> just launch CheckUserPrefFirst and CheckUserPrefLater in sequence.
>
> That way the preference store is created and written to, then that 
> process exits before a new process checks the written store.

Agree. Thank you, Brent!

Please review the updated version: 
http://cr.openjdk.java.net/~amlu/8209768/webrev.01/

Thanks,
Amy

>
> Other opinions?
>
> Thanks,
> -Brent
>
> On 10/22/18 8:46 PM, Amy Lu wrote:
>> Please review.
>>
>> Thanks,
>> Amy
>>
>> On 2018/10/11 4:47 PM, Amy Lu wrote:
>>> java/util/prefs/CheckUserPrefsStorage.sh
>>>
>>> Please review this patch to refactor above shell script test to java.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8209768
>>> webrev: http://cr.openjdk.java.net/~amlu/8209768/webrev.00/
>>>
>>> Thanks,
>>> Amy
>>



More information about the core-libs-dev mailing list