RFR: JDK-8212828 Allow POSIX_SPAWN to be used for ProcessImpl on Linux
Thomas Stüfe
thomas.stuefe at gmail.com
Wed Oct 24 13:51:51 UTC 2018
Hi David,
I think we need some form of test, as Alan indicated.
java/lang/ProcessBuilder/Basic.java should run through. Actually, I
would like it if we would run this test for all valid enabled launch
mechanisms, regardless which one is default. Can this be done?
To save time I will only rerun the tests once all reviews are
completed and the test is added.
Thanks, Thomas
On Wed, Oct 24, 2018 at 3:36 PM David Lloyd <david.lloyd at redhat.com> wrote:
>
> On Wed, Oct 24, 2018 at 1:05 AM Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> > Review:
> >
> > - copyright dates need updating on the C-sources
> >
> > - I opt for "#if defined(__solaris__) || defined(_ALLBSD_SOURCE) ||
> > defined(_AIX) || defined(__linux__)" to be removed completely from
> > unix-specific source files. The ifdef now covers all OpenJDK Unix
> > platforms.
>
> Here's a version with these changes.
>
> --
> - DML
More information about the core-libs-dev
mailing list