JDK 12 RFR of JDK-8212081: AnnotatedType.toString implementation don't print annotations on embedded types

[joe darcy]

Hi Joel,

Thanks for the review :-)

I'll push the 8212081.2 version with a few additional notes for future 
maintainers:

+    /*
+     * Note that if additional subclasses of AnnotatedTypeBaseImpl are
+     * added, the equals methods of AnnotatedTypeBaseImpl will need to
+     * be updated to properly implement the equals contract.
+     */
+
      private static class AnnotatedTypeBaseImpl implements AnnotatedType {

And inside AnnotatedWildcardTypeImpl.toString:

+        // Note that the wildcard API is written to accommodate
+        // multiple bounds for wildcards, but at the time of
+        // writing only a single bound is allowed in the
+        // language.

Thanks,

-Joe


On 10/29/2018 1:52 AM, Joel Borggrén-Franck wrote:
> Hi Joe,
>
> I suspect you pasted the wrong link, link to updated impl ends in 
> 8212081.2 right? Anyhow, the .2 version looks good. Ship it!
>
> Cheers
> /Joel
> /Joel
>