[12] RFR: 8212941: Loosen the range of JapaneseEra

[Naoto Sato]

Hi Chris,

Thank you for the review.

On 10/30/18 10:33 AM, Chris Hegarty wrote:
> 
>> On 30 Oct 2018, at 17:03, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>
>> Hi Naoto,
>>
>> Looks fine.  The wording should allow future Japanese era to be defined without
>> the timing being tightly coupled to java specification updates.
> 
> +1
> 
> Suggest:  "The defined ** era’s {@link #getValue} ** is expected
>    to have a consecutive integer associated with it.”
> 
> I suspect that the wording here has deliberately chosen, but I
> wonder if it could be tightened a little?
> 
> `values()` should return an array of eras whose values are in a
> contiguous range, no? If so, can this be specified?

Yes, both of those are valid points. I have already pushed the change, 
as the CSR has been approved, I will consider modifying the wording 
according to your suggestion in the future.

Naoto

> 
> -Chris.
> 
> 
>> Thanks, Roger
>>
>> On 10/30/2018 12:29 PM, Naoto Sato wrote:
>>> Updated the webrev. Please review.
>>>
>>> http://cr.openjdk.java.net/~naoto/8212941/webrev.03/
>