RFR: JDK-8200609 Proper fix for mapfile removal for libjsig

David Holmes david.holmes at oracle.com
Wed Sep 5 22:00:40 UTC 2018


Hi Magnus,

On 5/09/2018 10:11 PM, Magnus Ihse Bursie wrote:
> When I removed (mostly) all mapfiles for the JDK libraries, building of 
> libjsig started failing on Solaris, and that part was backed out.
> 
> Here's a new, and improved solution to remove the mapfile for libjsig, 
> even on Solaris.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200609
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8200609-remove-mapfile-for-libjsig/webrev.01 

Why are the forward declarations Solaris-only when the actual function 
definitions add JNIEXPORT unconditionally?

   37  * before including signal.h */
   38 #include "sys/signal.h"

Why do we need to include sys/signal.h rather than just (the existing) 
signal.h?

Thanks,
David

> 
> /Magnus
> 


More information about the core-libs-dev mailing list