RFR:8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

[vyom tewari]

Hi Chris,Daniel,

Please find the latest patch( 
http://cr.openjdk.java.net/~vtewari/8205330/webrev0.1/index.html ).

I did the additional cleanup(removed redundant null check) as you suggested.

Thanks,

Vyom


On Monday 10 September 2018 09:03 PM, Daniel Fuchs wrote:
> On 10/09/2018 15:53, vyom tewari wrote:
>> Yes , this will definitely solve this NPE issue but we may hit NPE 
>> other places as well because we are setting 'LdapClient.com' to null 
>> asynchronously.
>
> I agree with Vyom here.
>
> Other solutions that have been investigated - such as only
> setting the connection to null when its ref count reaches zero
> now seem to complex (read: too risky because over the complexity
> threshold) to me.
>
> Maybe the best thing to do here is to stick to Vyom original's
> idea, but declare conn final and do all the necessary (small)
> cleanup that goes with it? Possibly also add a comment saying
> that CommunicationException will be thrown if some other thread
> uses the LdapClient after forceClose has been closed...
>
> best regards,
>
> -- daniel
>