RFR - JDK-8210717 String::detab, String::entab (Code Review)

[Andrej Golovnin]

Hi Jim,

I'm not native english speaker. But that does not seem to be right for me:

2983      * @throws IllegalArgumentException if n is less that equals to zero.

3029      * @throws IllegalArgumentException if n is less that equals to zero.

I would write it as: if n is less than or equals to zero.

Best regards,
Andrej Golovnin
On Tue, Sep 18, 2018 at 7:53 PM Jim Laskey <james.laskey at oracle.com> wrote:
>
> Please review the code for String::detab and String::entab. Used to expand tabs into spaces, and spaces back to tabs.
>
> webrev: http://cr.openjdk.java.net/~jlaskey/8210717/webrev/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8210717
> csr: https://bugs.openjdk.java.net/browse/JDK-8210718
>
> Cheers,
>
> — Jim
>