[RFR] 8210810: Escaped character at specific position in argument file is not handled properly

[Henry Jen]

I’ll create back port requests.

Cheers,
Henry


> On Sep 27, 2018, at 11:06 PM, Bo Zhang <zhangbodut at gmail.com> wrote:
> 
> Thanks Henry, this change looks good to me. I assume this patch will be backported to 11GA, will it be back ported to 10 as well?
> 
> Regards,
> Bo
> 
>> On 28 Sep 2018, at 00:49, Henry Jen <henry.jen at oracle.com> wrote:
>> 
>> Agree, please find updated webrev[1].
>> 
>> [1] http://cr.openjdk.java.net/~henryjen/jdk/8210810/1/webrev/
>> 
>> Cheers,
>> Henry
>> 
>> 
>>> On Sep 27, 2018, at 1:45 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>> 
>>> On 27/09/2018 03:58, Henry Jen wrote:
>>>> Hi,
>>>> 
>>>> Need a quick review of the webrev[1] for JDK-8210810[2], it’s pretty much what Bo contributed, just add some trailing text “aaa\” to verify the integrity of escape sequence is handled properly.
>>>> 
>>>> I had reviewed the change and tested, but we need a “R”eviewer.
>>>> 
>>>> Cheers,
>>>> Henry
>>>> 
>>>> [1] http://cr.openjdk.java.net/~henryjen/jdk/8210810/webrev/
>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8210810
>>>> 
>>>> 
>>> The change to args.c looks okay but for the test then I assume it would be better to just add another test case to the existing ArgFileSyntax.java.
>>> 
>>> -Alan
>> 
>