RFR: 8216539: tools/jar/modularJar/Basic.java timed out

[Lance Andersen]

 A follow-up on this.

I ran this test 300+ times without failure on the internal Mach 5 machines including the one that it failed on (which was only 4 times since January).  This one system would run the test in approximately 6-7 minutes on average where as the the other window systems were running running around  1 - 1.5 minutes on average.

After a side-bar conversation with Mandy/Alan it was  suggested to  try to  use the ToolProvider API vs ProcessBuilder where applicable for invoking the  javac and jar commands.

With the change, the system that was running 6-7 minutes was down to 28 seconds on average on the slow machine.


The webrev can be found at: http://cr.openjdk.java.net/~lancea/8216539/webrev.01/index.html



> On Mar 27, 2019, at 8:23 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
> 
> On 3/27/19 4:56 PM, Lance Andersen wrote:
>> Hi Mandy,
>> 
>> 
>>> On Mar 27, 2019, at 7:23 PM, Mandy Chung <mandy.chung at oracle.com <mailto:mandy.chung at oracle.com>> wrote:
>>> 
>>> Hi Lance,
>>> 
>>> Do you understand what takes so long for this test to run?
>> 
>> Well it is executing a lot of jar commands.  I did not see anything that sticks out in the failed logs that point to anything obvious.
> 
> One thing you could do is to instrument the test to gather the timing statistics.
> 
>>> Is it running fastdebug and -Xcomp or other flag?
>> 
>> It is just a standard windows run.
> 
> This is even strange if it's running normal product build.
> 
> Mandy
> 
>>> 
>>> Mandy
>>> 
>>> On 3/27/19 1:55 PM, Lance Andersen wrote:
>>>> Hi all ,
>>>> 
>>>> Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 <https://bugs.openjdk.java.net/browse/JDK-8216539> which increases the timeout value for this test which fails once in a blue moon on windows.
>>>> 
>>>> 
>>>> ———————
>>>> $ hg diff
>>>> diff -r dc66ada06693 test/jdk/tools/jar/modularJar/Basic.java
>>>> --- a/test/jdk/tools/jar/modularJar/Basic.java	Tue Mar 26 15:36:19 2019 -0700
>>>> +++ b/test/jdk/tools/jar/modularJar/Basic.java	Wed Mar 27 16:50:53 2019 -0400
>>>> @@ -54,7 +54,7 @@
>>>>   *        jdk.test.lib.util.FileUtils
>>>>   *        jdk.test.lib.JDKToolFinder
>>>>   * @compile Basic.java
>>>> - * @run testng Basic
>>>> + * @run testng/timeout=300 Basic
>>>>   * @summary Tests for plain Modular jars & Multi-Release Modular jars
>>>>   */
>>>>  
>>>> 
>>>> ——————————
>>>> 
>>>> Best
>>>> Lance
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering 
>>>> 1 Network Drive 
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com>
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering 
>>>> 1 Network Drive 
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com>
>>>> 
>>>> 
>>>> 
>>> 
>> 
>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>