RFR: 8221397 Support implementation-defined Map Modes

Alan Bateman Alan.Bateman at oracle.com
Tue Apr 2 10:22:52 UTC 2019


On 02/04/2019 10:12, Andrew Dinn wrote:
> Could I please have reviews for the following enhancement:
>
> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8221397
> webrev: http://cr.openjdk.java.net/~adinn/8221397/webrev.00/
>
This updates the description for 
NonReadableChannelException/NonWriteableChannelException, I assume you 
didn't mean to include that in the patch.

A corner case to consider is whether a map mode can be the empty string, 
maybe IAE should be thrown for that case.

Are you planning a test to go along with this? It can test that the map 
method throws UOE and it can test the MapMode constructor.

-Alan


More information about the core-libs-dev mailing list