(1-line) Review Request: 8222078: test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c build fails after 8221530

Alan Bateman Alan.Bateman at oracle.com
Sun Apr 7 08:49:26 UTC 2019



On 07/04/2019 09:12, Mandy Chung wrote:
> It needs another fix for windows build:
>
> diff --git a/make/test/JtregNativeJdk.gmk b/make/test/JtregNativeJdk.gmk
> --- a/make/test/JtregNativeJdk.gmk
> +++ b/make/test/JtregNativeJdk.gmk
> @@ -61,6 +61,7 @@
>    BUILD_JDK_JTREG_LIBRARIES_LIBS_libstringPlatformChars := 
> $(WIN_LIB_JAVA)
>    WIN_LIB_JLI := $(SUPPORT_OUTPUTDIR)/native/java.base/libjli/jli.lib
>    BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeJliLaunchTest := $(WIN_LIB_JLI)
> +  BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeCallerAccessTest := jvm.lib
>  else
>    BUILD_JDK_JTREG_LIBRARIES_LIBS_libstringPlatformChars := -ljava
>    BUILD_JDK_JTREG_LIBRARIES_LIBS_libDirectIO := -ljava
> @@ -70,10 +71,9 @@
>      BUILD_JDK_JTREG_LIBRARIES_LIBS_libInheritedChannel := -ljava 
> -lsocket -lnsl
>    endif
>    BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeJliLaunchTest := -ljli
> +  BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeCallerAccessTest := -ljvm
>  endif
>
> -BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeCallerAccessTest := -ljvm
> -
>  ifeq ($(call isTargetOs, macosx), true)
>    BUILD_JDK_JTREG_LIBRARIES_CFLAGS_libTestMainKeyWindow := -ObjC
>    BUILD_JDK_JTREG_LIBRARIES_LIBS_libTestMainKeyWindow := -framework 
> JavaVM \
I think this looks okay and seems to work for me locally too.

-Alan


More information about the core-libs-dev mailing list