RFR (XS) 8222111: exeCallerAccessTest.c fails to build: control reaches end of non-void function

[David Holmes]

+1

Strange that an old gcc complains but the newer ones that add more and 
more warnings each time, let this slip through :(

Arguably all the exit(-1) in the main method should just be return -1 
instead - but that's a different matter.

Thanks,
David

On 8/04/2019 10:08 pm, Alan Bateman wrote:
> On 08/04/2019 12:54, Aleksey Shipilev wrote:
>> Bug:
>>    https://bugs.openjdk.java.net/browse/JDK-8222111
>>
>> Fix:
>>
>> diff -r 0d7fb7f07134 
>> test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c
>> --- 
>> a/test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c      
>> Mon Apr 08 06:56:37
>> 2019 +0100
>> +++ 
>> b/test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c      
>> Mon Apr 08 13:53:51
>> 2019 +0200
>> @@ -94,4 +94,5 @@
>>
>>       (*jvm)->DestroyJavaVM(jvm);
>> +    return 0;
>>   }
>>
> This test seems to having trouble bedding in. I don't know which gcc 
> version it falls foul of the above but the patch looks okay to me.
> 
> -Alan