RFR: JDK-8221749: Error messages
Andy Herrick
andy.herrick at oracle.com
Tue Apr 9 11:45:17 UTC 2019
On 4/8/2019 6:05 PM, Andy Herrick wrote:
>
> On 4/8/2019 5:41 PM, Alexander Matveev wrote:
>> Hi Andy,
>>
>> Looks good.
>>
>> Also, many messages (including added in this review) in
>> MainResources.properties do have "." at the end and some don't. I
>> think we should cleanup it and add "." if needed.
> Yes - some messages are not full sentences, but most are. Those that
> are should end in a period.
> I will address that in the next clean-up change.
> /Andy
Instead of addressing in the next cleanup change, I am revising this
webrev (see webrev.02 at [1]) adding period to end of sentences and
other simple cleanups.
/Andy
>>
>> Thanks,
>> Alexander
>>
>> On 4/8/2019 4:41 AM, Andy Herrick wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>>> repository (jpackage).
>>>
>>> [1] http://cr.openjdk.java.net/~herrick/8221749/
>>>
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8221749/
>>>
>>> /Andy
>>
>
More information about the core-libs-dev
mailing list