[8u] 8205432: Replace the placeholder Japanese era name

[Hohensee, Paul]

+1.

Paul

On 4/8/19, 8:28 PM, "core-libs-dev on behalf of Andrew John Hughes" <core-libs-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    On 08/04/2019 09:25, Deepak Kejriwal wrote:
    > Hi Andrew,
    > 
    > Thanks for working on this. Please find below few minor comments:-
    > 
    > 1>. For "src/share/classes/java/util/JapaneseImperialCalendar.java" and "src/share/classes/sun/util/calendar/Era.java" please changes the date time format to be consistent with existing defined eras:-
    >   *     4       Heisei      1989-01-08 midnight local time
    > - *     5       NewEra      2019-05-01 midnight local time
    > + *     5       Reiwa       2019-05-01T00:00:00 local time
    > 
    > Please change "2019-05-01T00:00:00 local time" to "2019-05-01 midnight local time"
    > 
    
    The change in style is a cleanup that is part of JDK-8048123 [0]. I
    think we're better bringing over those cleanups than making Reiwa use
    the bad format, so I've incorporated those parts of [1] into the revised
    webrev.
    
    > 2>.  For "test/java/time/test/java/time/chrono/TestJapaneseChronology.java" please align "JapaneseEra.of(3)" with existing defined eras in "Object[][] eraNameData()".
    > 
    
    I've fixed this too, but note that this comes from the original patch in
    11 and up. So it actually needs fixing there too.
    
    Revised webrev:
    https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/
    
    > 
    > Regards,
    > Deepak
    > 
    
    [0] https://mail.openjdk.java.net/pipermail/i18n-dev/2014-July/001438.html
    [1] https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/91ea77c474b9
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew