RFR: JDK-8222151: refactoring: enhancements to java.lang.Class::methodToString and java.lang.Class::getTypeName

Vicente Romero vicente.romero at oracle.com
Thu Apr 11 20:30:36 UTC 2019


Hi Joe,

Thanks for the review please, I have modified the webrev [1]

[1] http://cr.openjdk.java.net/~vromero/8222151/webrev.01/

On 4/11/19 1:26 PM, Joseph D. Darcy wrote:
> Hi Vicente,
>
> For methodToString, factoring out computing the common
>
>     getName() + '.' + name
>
> prefix might be preferable, but otherwise the patch looks fine.
>
> Thanks,
>
> -Joe
>
> On 4/11/2019 10:22 AM, Vicente Romero wrote:
>> Please review the enhancements to java.lang.Class proposed by Sergei 
>> Tsypanov see discussion at [1]. The bug can be found at [2] and the 
>> fix at [3]. This enhancement is removing uses of StringBuilder in:
>>     ::toGenericString
>>     ::methodToString, and
>>     ::getTypeName
>>
>> Thanks,
>> Vicente
>>
>> [1] 
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-March/059110.html
>> [2] https://bugs.openjdk.java.net/browse/JDK-8222151
>> [3] http://cr.openjdk.java.net/~vromero/8222151/webrev.00/
>



More information about the core-libs-dev mailing list