RFR: 8222334: java -Xss0 triggers StackOverflowError

[Patrick Zhang OS]

Sure I will add this, and fix the intention mentioned by Alan.

Regards
Patrick

-----Original Message-----
From: David Holmes <david.holmes at oracle.com> 
Sent: Tuesday, April 16, 2019 4:17 PM
To: Patrick Zhang OS <patrick at os.amperecomputing.com>
Cc: Alan Bateman <Alan.Bateman at oracle.com>; core-libs-dev <core-libs-dev at openjdk.java.net>
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

Patrick,

Sorry should have picked up on this earlier. Can you please update the following two tests to add a test for '0' as appropriate:

./jdk/tools/launcher/TooSmallStackSize.java
./hotspot/jtreg/runtime/Thread/TooSmallStackSize.java

Thanks,
David

On 16/04/2019 5:47 pm, David Holmes wrote:
> On 16/04/2019 5:40 pm, Alan Bateman wrote:
>> On 15/04/2019 08:48, David Holmes wrote:
>>> On 15/04/2019 5:34 pm, Patrick Zhang OS wrote:
>>>> Removed it. 
>>>> http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changeset
>>>>
>>>> By the way, could you please sponsor to push it once approved? 
>>>> thanks in advance.
>>>
>>> Sure - if the core-libs person who also reviews doesn't volunteer 
>>> (hint hint ;-) )
>> This looks okay to me too, I think we should fix the intention in 
>> ContinueInNewThread while we are there so it matches the rest of the 
>> file.
> 
> Thanks Alan! I'll fix the indent before pushing.
> 
> David
> -----
> 
>> -Alan