RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

[Joe Wang]

Thanks Lance!  Pushed after changing 3078/79 back to 3078.

Best,
Joe

On 4/16/19, 1:14 PM, Lance Andersen wrote:
> Hi Joe,
>
> Overall, I think the updates look OK.  One minor correction/cleanup 
> for before you push is in the XMLEntityManager line 3078/79 to move 
> back the else to 3078
>
> No need to update the webrev
>
> HTH
>
> Best
> Lance
>> On Apr 15, 2019, at 3:46 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Please review an update from Xerces in the configuration area. The 
>> patch contains changes not easily measurable with test (e.g. a few 
>> bytes for a parse, or small leaks for a file as large as a GB, or 
>> none at all). But the change does improve in that a method ( 
>> readAndBuffer) that explicitly buffers was provided so that the 
>> processes that required buffer all call it instead of the general 
>> read method. While there's a small test added, the testing  was 
>> focused on getting the existing ones to pass.
>>
>> All XML-related tests in the core tests and JCK passed.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222415
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8222415/webrev/ 
>> <http://cr.openjdk.java.net/%7Ejoehw/jdk13/8222415/webrev/>
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>