RFR: JDK-8219683,,Modify App Image layout on Mac

Phil Race philip.race at oracle.com
Fri Apr 19 18:20:32 UTC 2019


+1

Only thing I have to say is that in the test JPackagePath I
liked the esier to read formatting you didhere at lines 184-185 and you
could have done something similar at lines 159-161

+ + File.separator + "Contents"
+ + File.separator + "runtime"
+ + File.separator + "Contents"
+ + File.separator + "Home" + File.separator + "bin";

-phil.

On 4/19/19 10:46 AM, Kevin Rushforth wrote:
> Looks good.
>
> -- Kevin
>
>
> On 4/19/2019 9:32 AM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8219683
>>
>> [2] http://cr.openjdk.java.net/~herrick/8219683/
>>
>> /Andy
>>
>



More information about the core-libs-dev mailing list