[14] RFR: 8215181: Accounting currency format support

[Roger Riggs]

+1,

Bundle.java:226:  there is a slight preference for String.isEmpty() 
over  String.length() == 0

Thanks, Roger

On 8/7/19 4:26 PM, Lance Andersen wrote:
> awesome, I must have missed it thinking it was a bug when I reviewed the bug itself (long day :-) ) ….
>
>> On Aug 7, 2019, at 4:24 PM, naoto.sato at oracle.com wrote:
>>
>> Thanks for the review, Lance.
>>
>> Yes, CSR is needed and it is already approved:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8218770
>>
>> Naoto
>>
>> On 8/7/19 1:20 PM, Lance Andersen wrote:
>>> Hi again Naoto,
>>> I meant to ask is there a CSR due to the change in the javadoc for NumberFormat?  If not, there probably should
>>>> On Aug 7, 2019, at 4:17 PM, Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> wrote:
>>>>
>>>> Hi Naoto,
>>>>
>>>> I looked over the proposed changes and the bug.  They seem reasonable to me.
>>>>
>>>> Best
>>>> Lance
>>>>> On Aug 7, 2019, at 4:12 PM, naoto.sato at oracle.com <mailto:naoto.sato at oracle.com> wrote:
>>>>>
>>>>> Ping.
>>>>>
>>>>> Naoto
>>>>>
>>>>> On 7/31/19 5:57 PM, naoto.sato at oracle.com <mailto:naoto.sato at oracle.com> wrote:
>>>>>> Hi,
>>>>>> Please review the fix to the following issue:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8215181
>>>>>> The proposed changeset is located at:
>>>>>> https://cr.openjdk.java.net/~naoto/8215181/webrev.00/
>>>>>> This is to enable "accounting" style currency formatting (negative values in parentheses) with CLDR.
>>>>>> Naoto
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com>
>>>>
>>>>
>>>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>