RFR: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale
Thejasvi Voniadka
thejasvi.v.voniadka at oracle.com
Thu Aug 8 00:55:44 UTC 2019
Hi Naoto,
Thank you for the review. This change has now been pushed.
-----Original Message-----
From: Naoto Sato
Sent: Thursday, August 01, 2019 9:43 PM
To: Thejasvi Voniadka <thejasvi.v.voniadka at oracle.com>; i18n-dev at openjdk.java.net; core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale
Looks good to me, Thejasvi.
Naoto
On 8/1/19 6:42 AM, Thejasvi Voniadka wrote:
> Hi,
>
> Request you to please review this change.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8158880 (test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale)
>
> Description: The test " test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java# test_appendZoneText_parseGenericTimeZonePatterns" fails if run on certain locales (such as "ja"). At present the test does not enforce a specific locale for the DateTimeFormatter, and hence the machine's locale is used as the default. This could cause parsing mismatches when run on non-US locales. The fix is to set the locale explicitly in the test.
>
> Webrev: http://cr.openjdk.java.net/~vagarwal/8158880/webrev.0
>
>
>
More information about the core-libs-dev
mailing list