RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

[naoto.sato at oracle.com]

Hi Lance,

Yes, I would like the style, but AFAIK, all java.time tests are testng, 
and controlled with the java/time/{test/tck}/TEST.properties file so 
that each test file won't need jtreg tags (it cannot override them either).

Naoto

On 8/12/19 3:17 PM, Lance Andersen wrote:
> Hi Naoto,
>> On Aug 12, 2019, at 6:01 PM, naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com> wrote:
>>
>> Thank you for the review, Lance.
>>
>> On 8/12/19 2:37 PM, Lance Andersen wrote:
>>> Looks good Naoto.
>>> One question I had which is not relevant to your fix, but should the 
>>> tests as we modify them include the JTReg tags such as @bug, 
>>> @summary…. etc…  just for consistency….
>>
>> I put @bug tags to each of the modified test, but not @summary, et.al. 
>> It seems that each test file corresponds to the java.time class, so 
>> adding @summary for this bug might not fit. I could add @summary to 
>> existing "Tests XXXX" statement, but keep it consistent with other 
>> java.time test case files.
> 
> I was thinking more similar to:
> 
> open/test/jdk/jdk/nio/zipfs/TestPosix.java or 
> open/test/jdk/java/nio/file/Files/StreamTest.java
> 
> ——————
> 
> /* @test
> * @bug 8006884 8019526 8132539
> * @library ..
> * @build PassThroughFileSystem FaultyFileSystem
> * @run testng StreamTest
> * @summary Unit test for java.nio.file.Files methods that return a Stream
> */
> 
> ————————
> 
> You won’t need the @run for these tests but each test is for a specific 
> class such as OffsetDateTime and ZonedOffSetDateTime and all of the bugs 
> are listed at the top of the file.
> 
> I am not sure we have agreed to standardize this historically, but I 
> tend to when I update a test if applicable.
> 
> Anyways, just a suggestion… Feel free to ignore ;-)
> 
> Have a good rest of your evening :-)
> 
>>
>> Naoto
>>
>>> Best
>>> Lance
>>>> On Aug 12, 2019, at 4:43 PM, naoto.sato at oracle.com 
>>>> <mailto:naoto.sato at oracle.com> <mailto:naoto.sato at oracle.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> Please review the fix to the following issue:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8211990
>>>>
>>>> The proposed changeset is located at:
>>>>
>>>> https://cr.openjdk.java.net/~naoto/8211990/webrev.00/
>>>>
>>>> The DateTimeException was thrown due to unconditional conversion 
>>>> beyond the valid range of the internal LocalDateTime value. If it 
>>>> happens, normalize two instants with the offset of "start" instant. 
>>>> The same kind of exception is observed with ZonedDateTime.until(), 
>>>> which is also fixed in this changeset.
>>>>
>>>> Naoto
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com> 
>>> <mailto:Lance.Andersen at oracle.com>
> 
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
>